Fix package_cache_async missing from ResolvedContext dict round-trip
#1810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Rusch <nathan.rusch@scanlinevfx.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1810 +/- ##
=======================================
Coverage 58.52% 58.52%
=======================================
Files 126 126
Lines 17206 17207 +1
Branches 3519 3519
=======================================
+ Hits 10069 10070 +1
Misses 6468 6468
Partials 669 669 ☔ View full report in Codecov by Sentry. |
JeanChristopheMorinPerso
merged commit 8476696
into
AcademySoftwareFoundation:main
47 checks passed
Pixel-Minions
added a commit
to Pixel-Minions/rez
that referenced
this pull request
Sep 26, 2024
…rip. Also bumped the serialization formation from 4.7 to 4.8 (AcademySoftwareFoundation#1810) Signed-off-by: Nathan Rusch <nathan.rusch@scanlinevfx.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up fix to #1679
The new
package_cache_asyncattribute on theResolvedContextclass was not being round-tripped through the context serialization process. This leads to the following error after spawning a shell (when therezolve contextcommand runs):I will note that it seems a bit strange for
ResolvedContext.from_dictto callcontext._update_package_cache()after creating a new instance, but I assume there are some historical reasons for this. However, given this pattern, ifpackage_cache_asyncis set toFalse,from_dictcould potentially block for a very long time.CC @isohedronpipeline for visibility.